Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted issue templates to use Forms #4413

Merged
merged 13 commits into from
Dec 15, 2021

Conversation

Arlodotexe
Copy link
Member

Fixes

Fixes #4177

PR Type

What kind of change does this PR introduce?

  • Other: GitHub feature

What is the current behavior?

Markdown is used for issue templates.

What is the new behavior?

Updates templates to use the new "GitHub Forms Schema"

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Dec 3, 2021

Thanks Arlodotexe for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi December 3, 2021 18:55
@net-foundation-cla
Copy link

net-foundation-cla bot commented Dec 3, 2021

CLA assistant check
All CLA requirements met.

@net-foundation-cla
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ Arlodotexe sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@ghost ghost added documentation 📃 feature request 📬 A request for new changes to improve functionality labels Dec 3, 2021
@ghost
Copy link

ghost commented Dec 9, 2021

This PR has been marked as "needs attention 👋" and awaiting a response from the team.

@Arlodotexe
Copy link
Member Author

@michael-hawker Ping, should be all finished here

@michael-hawker
Copy link
Member

@XAML-Knight think we're all good now, eh? Any other concerns?

@ghost ghost removed the needs attention 👋 label Dec 15, 2021
Copy link
Contributor

@XAML-Knight XAML-Knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - devs will probably prefer to interact with these new templates.

@Arlodotexe Arlodotexe merged commit 213d3f2 into CommunityToolkit:main Dec 15, 2021
@Arlodotexe Arlodotexe deleted the Arlodotexe/issue4177 branch December 15, 2021 18:56
@michael-hawker michael-hawker added this to the 7.1.3 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📃 feature request 📬 A request for new changes to improve functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Update Issue Templates to use Issue Form template GitHub feature
3 participants