☠️ GridSplitter refactor w/ new base class #4463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content Sizer Issues: - [ ] TargetControl isn't loaded yet causes problems (Expander Issue) - [ ] Size Direction needs to be more specific (only works Left/Top, not Right/Bottom) - [ ] Do we support 'Auto'? - [ ] Need to set Automation Property Name in Code-Behind - [ ] Content Initial value as binding converter to ResizeDirection?
Bonus also fixes issue with sample loading the first time...
Allows for access to VisualTree within UI Test Uses System.Test.Json serialization to return UI object info between host/harness Added intial basic GridSplitter tests to validate (though unsure why there's such a large variance in delta from drag... test is reporting moved the right number of requested pixels, so not sure if issue with delta vs. completed in GridSplitter itself)
|
Thanks XAML-Knight for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
|
Rebase issue; will submit this branch again after resolving rebase |
XAML-Knight
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: for those following along at home, check out the new residence of this refactoring effort: michael-hawker#3
Follow up to #4083
PR Type
What kind of change does this PR introduce?
Refactoring (no functional changes, no api changes)
What is the current behavior?
The pair of controls
GridSpliterandContentSizershare a lot of the same functionality.What is the new behavior?
The plan is to refactor out all the common base functionality of
GridSplitter&ContentSizer, and add them to a common base class (SplitBase).Also includes, but is not limited to, the following updates:
- Addressed by adding a new bool variable
InvertDragDirectionPR Checklist
Please check if your PR fulfills the following requirements:
Other information