Expander control #707
Closed
Expander control #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r usage (yay for tests)
Conflicts: Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj Microsoft.Toolkit.Uwp.SampleApp/SamplePages/samples.json
Conflicts: Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj Microsoft.Toolkit.Uwp.UI.Controls/Microsoft.Toolkit.Uwp.UI.Controls.csproj Microsoft.Toolkit.Uwp.UI.Controls/Themes/Generic.xaml
Conflicts: Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj
Conflicts: Microsoft.Toolkit.Uwp.UI.Controls/Themes/Generic.xaml
… the first subscriber to the BackRequested event Fixes #641
…ot/UWPCommunityToolkit into MasterDetailsBackBehavior
Conflicts: Microsoft.Toolkit.Uwp.UI.Controls/Themes/Generic.xaml
Pull from MS main
Documentation for ListViewBaseExtensions and link to readme.md
AdvancedCollectionView docs
Renamed MosaicControl to TileControl
Documentation tab for sample app
using MD to display useful inks
Fixed warnings
Update summary tag of ItemClickCommand
|
Ping :) last call for 1.3 :) |
|
Will do in a few hours. :) |
|
Thanks :) |
|
Wow, I don't know why so many commits have been added to this branch. Otherwise, I made the changes you requested. |
|
Wooot! Seems good but cannot merge with so many unrelated files :( |
|
Also noticed that XML docs is missing on some properties |
|
Looks like maybe a bad merge |
|
Other question: Should we apply the pointerUp/Down on RootGrid? Or only to the arrow? |
|
@skendrot It never happened before and I did not change the way I merge. Clearly, I don't know why. I'll create a new PR so. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #115
I have created the Expander control for the toolkit based on this project https://github.com/deanchalk/ExpanderUWP
I don't know if there is another intention for this control.