Replace linker suppressions with attributes #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
force-pushed
the
dev/fix-linker-pragma-suppressions
branch
from
b72ac10 to
321fc50
Compare
Comment on lines
615
to
+619
| // Get or compute the cached list of properties to validate. Here we're using a static lambda to ensure the | ||
| // delegate is cached by the C# compiler, see the related issue at https://github.com/dotnet/roslyn/issues/5835. | ||
| EntityValidatorMap.GetValue(GetType(), static t => GetValidationAction(t))(this); | ||
| EntityValidatorMap.GetValue( | ||
| GetType(), | ||
| [RequiresUnreferencedCode("The type of the current instance cannot be statically discovered.")] static (t) => GetValidationAction(t))(this); |
There was a problem hiding this comment.
You can now just write GetValidationAction. The linked Roslyn issue has been closed.
There was a problem hiding this comment.
The issue is closed but the fix is slated for the C# 11 timeslot, I don't think it's there in VS stable just yet, meaning our CI will be using an older version of Roslyn too without that. I would keep that as is for now (especially given it's unrelated from this PR anyway), and we can update this later on when we bump the SDK as well 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @vitek-karas here (dotnet/linker#2938 (comment)), using
#pragma warning disablefor linker annotations is incorrect, as it won't prevent those warnings from actually being emitted. This PR removes the few the MVVM Toolkit had, and just adds the proper annotations to remove the warnings.cc. @kant2002
PR Checklist