Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IBufferWriterExtensions type of exception thrown documentation #497

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Fix IBufferWriterExtensions type of exception thrown documentation #497

merged 1 commit into from
Nov 16, 2022

Conversation

pziezio
Copy link
Contributor

@pziezio pziezio commented Nov 13, 2022

Closes #496

Fixes documentation of thrown exceptions in CommunityToolkit.HighPerformance.IBufferWriterExtensions.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Contains NO breaking changes

@net-foundation-cla
Copy link

net-foundation-cla bot commented Nov 13, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

Sergio0694
Sergio0694 approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Thank you!

@Sergio0694 Sergio0694 merged commit ad50acb into CommunityToolkit:main Nov 16, 2022
@Sergio0694 Sergio0694 added documentation 📃 Some proposed change related to documentation high-performance 🚂 Issues/PRs for the HighPerformance package labels Nov 16, 2022
@pziezio pziezio deleted the ibufferwriterextensions-fix-xmldoc branch November 16, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sergio0694 Sergio0694 Sergio0694 approved these changes

Assignees
No one assigned
Labels
documentation 📃 Some proposed change related to documentation high-performance 🚂 Issues/PRs for the HighPerformance package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid documentation of exceptions thrown in IBufferWriterExtensions
2 participants
@pziezio @Sergio0694