Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analyzer for references to fields with [ObservableProperty] #532

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Add analyzer for references to fields with [ObservableProperty] #532

merged 4 commits into from
Dec 13, 2022

Conversation

Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Dec 11, 2022 •
edited
Loading

Closes #518

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Dec 11, 2022
@Sergio0694 Sergio0694 force-pushed the dev/observable-property-field-reference-analyzer branch from 39a7de5 to 35e3584 Compare December 12, 2022 20:36
@Sergio0694 Sergio0694 marked this pull request as ready for review December 12, 2022 20:36
@Sergio0694 Sergio0694 merged commit 4600382 into main Dec 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/observable-property-field-reference-analyzer branch December 13, 2022 11:56
@Sergio0694 Sergio0694 mentioned this pull request Dec 14, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Awaiting requested review from Arlodotexe

Assignees
No one assigned
Labels
analyzer 👓 A new analyzer being implemented or updated mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an analizer to mvvm toolkit to warn when I use fields instead of generated properties
1 participant
@Sergio0694