Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit diagnostic for unresolved property: attribute over [ObservableProperty] field #564

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Emit diagnostic for unresolved property: attribute over [ObservableProperty] field #564

merged 2 commits into from
Jan 16, 2023

Conversation

Sergio0694
Copy link
Member

Contributes to #563

This PR adds a diagnostic if a property: attribute over a field using [ObservableProperty] isn't resolved correctly:

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Jan 16, 2023
@Sergio0694 Sergio0694 changed the title Dev/property attribute diagnostic Emit diagnostic for unresolved property: attribute over [ObservableProperty] field Jan 16, 2023
@Sergio0694 Sergio0694 merged commit 302b8a9 into main Jan 16, 2023
@Sergio0694 Sergio0694 deleted the dev/property-attribute-diagnostic branch January 16, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sergio0694