Add diagnostics for invalid expressions for forwarded attributes #684

Sergio0694 · 2023-05-07T13:19:46Z

Closes #683

PR Checklist

Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
Based off latest main branch of toolkit
PR doesn't include merge commits (always rebase on top of our main, if needed)
Tested code with current supported SDKs
New component
- Pull Request has been submitted to the documentation repository instructions. Link:
Tests for the changes have been added (for bug fixes / features) (if applicable)
Header has been added to all new source files (run build/UpdateHeaders.bat)
Contains NO breaking changes
Every new API (including internal ones) has full XML docs
Code follows all style conventions

Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug labels May 7, 2023

Sergio0694 marked this pull request as draft May 7, 2023 13:25

Sergio0694 force-pushed the dev/fix-attribute-expressions branch from 4315699 to 96a6e8f Compare May 7, 2023 18:31

Sergio0694 marked this pull request as ready for review May 7, 2023 18:31

Sergio0694 requested a review from Arlodotexe May 8, 2023 10:47

Sergio0694 force-pushed the dev/fix-attribute-expressions branch 3 times, most recently from 2801329 to a3a6d8f Compare May 10, 2023 14:28

Sergio0694 added 2 commits May 10, 2023 16:47

Add diagnostics when forwarded invalid attributes

51a0ebf

Add unit tests for new attribute expression diagnostics

01f07fe

Sergio0694 force-pushed the dev/fix-attribute-expressions branch from a3a6d8f to 01f07fe Compare May 10, 2023 14:47

Arlodotexe approved these changes May 10, 2023

View reviewed changes

Sergio0694 merged commit 6fe5b48 into main May 11, 2023

delete-merged-branch bot deleted the dev/fix-attribute-expressions branch May 11, 2023 11:28