Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .targets to validate the Windows SDK version #942

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Add .targets to validate the Windows SDK version #942

merged 2 commits into from
Sep 12, 2024

Conversation

Sergio0694
Copy link
Member

This PR adds a new .targets to validate the Windows SDK package version and emit an error if not valid.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added build 🔥 Some changes or issues related to build infrastructure introduce breaking changes 💥 This change would be a breaking change nuget 📦 Changes or issues related to NuGet publishing mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Sep 8, 2024
@Sergio0694 Sergio0694 force-pushed the dev/windows-sdk-validation branch 4 times, most recently from f3e045c to 8d18f74 Compare September 9, 2024 12:03
@Sergio0694 Sergio0694 merged commit 04c514c into main Sep 12, 2024
4 checks passed
@Sergio0694 Sergio0694 deleted the dev/windows-sdk-validation branch September 12, 2024 13:26
Sergio0694 added a commit that referenced this pull request Sep 12, 2024
@Sergio0694
Merge pull request #942 from CommunityToolkit/dev/windows-sdk-validation
3c7ef2f 
Add .targets to validate the Windows SDK version
This was referenced Sep 12, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build 🔥 Some changes or issues related to build infrastructure introduce breaking changes 💥 This change would be a breaking change mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit nuget 📦 Changes or issues related to NuGet publishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sergio0694