Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call stack information is sometimes incorrect in perf output #2

Open
Chadderz121 opened this issue Nov 24, 2023 · 0 comments
Open

Call stack information is sometimes incorrect in perf output #2

Chadderz121 opened this issue Nov 24, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Chadderz121
Copy link
Collaborator

Sometimes perf seems to output incorrect call stacks, and this compromises the accuracy of statistics.
@Chadderz121 Chadderz121 added the bug Something isn't working label Nov 24, 2023
Chadderz121 added a commit that referenced this issue Feb 7, 2024
@Chadderz121
Detect function nesting information.
2777b40 
This patch means that for each function we compute the call site and function
that dominates this call in the CFG with returns removed. Hence in particular we
know that if a sample occurs in a particular function, all the dominating
functions must be on the stack, and so we can detect missing stack frames in the
perf output. This addresses issue #2 as best as reasonably possible, without
better output from perf.

This patch will also support future output of the program structure.
@Chadderz121 Chadderz121 mentioned this issue Feb 7, 2024
Merged
intheRain07 pushed a commit that referenced this issue Feb 8, 2024
@Chadderz121 @intheRain07
Detect function nesting information.
d308866 
This patch means that for each function we compute the call site and function
that dominates this call in the CFG with returns removed. Hence in particular we
know that if a sample occurs in a particular function, all the dominating
functions must be on the stack, and so we can detect missing stack frames in the
perf output. This addresses issue #2 as best as reasonably possible, without
better output from perf.

This patch will also support future output of the program structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Chadderz121