Delay analyze disassembly parse errors. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`optiwise analyze` eagerly reported parse errors in reading the `optiwise disassemble` output, but this is unnecessary if the parse error won't actually affect the analysis. This patch delays the errors until the given module is actuaqlly referenced, so that small errors in irrelevant modules don't ruin the analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optiwise analyzeeagerly reported parse errors in reading theoptiwise disassembleoutput, but this is unnecessary if the parse error won't actually affect the analysis. This patch delays the errors until the given module is actually referenced, so that small errors in irrelevant modules don't ruin the analysis.This addresses one of the problems in issue #20