Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

as_json is returning all nodes as an array #10

Closed
chadwilken opened this issue Nov 2, 2023 · 0 comments · Fixed by #11
Closed

as_json is returning all nodes as an array #10

chadwilken opened this issue Nov 2, 2023 · 0 comments · Fixed by #11
Assignees
@chadwilken

Comments

@chadwilken
Copy link
Collaborator

When using the library with Rails the Enumerable#as_json method is overriding the implementation in HasContent and breaking real-world usage.
@chadwilken chadwilken self-assigned this Nov 2, 2023
chadwilken added a commit that referenced this issue Nov 2, 2023
@chadwilken
Rename as_json to to_h
b6bbee7 
Closes #10
@chadwilken chadwilken mentioned this issue Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chadwilken chadwilken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename as_json to to_h CompanyCam/tiptap-ruby
1 participant
@chadwilken