Add support for additional image attributes #23
Conversation
|
@jeffmcfadden @chadwilken hey y'all, I wanted to ping to see what you thought about this PR? It doesn't look like I can select any one for a review. Thanks! |
@notnek thanks for opening a PR. I think this looks good. I'm trying to think if there would be any security vulnerabilities possible by allowing all attributes to be passed to |
| @@ -12,7 +12,7 @@ def include_empty_content_in_json? | |||
| end | |||
|
|
|||
| def to_html | |||
| image_tag(src) | |||
| image_tag(src, attrs.except("src")) | |||
There was a problem hiding this comment.
I wonder if the goal is setting alt that we just allow alt or at minimum the allow options that can be passed to the image_tag helper. https://api.rubyonrails.org/v7.2.2/classes/ActionView/Helpers/AssetTagHelper.html#method-i-image_tag
There was a problem hiding this comment.
I'm happy to change it to only set alt for now.
There was a problem hiding this comment.
That would be great, thanks!
Description
Adds support for setting additional attributes beyond
srcon the image node HTML output.Reason/Reference
Currently the implementation doesn't allow for alt text (or any other attribute) to be set.
—
Thanks for the excellent work on this gem!