T1657 - Fix invoice generation for Sub Proposal (1/3) #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prazn
changed the title
Prazn
changed the title
This was referenced Aug 15, 2024
Merged
Prazn
commented
Aug 15, 2024
Prazn
commented
Aug 15, 2024
Prazn
commented
Aug 15, 2024
ecino
requested changes
Aug 19, 2024
ecino
requested changes
Aug 20, 2024
|
You also have conflicts with the latest 14.0 version. |
…voices are generated, specially in the case where we pass a specific conteact to generate the invoices of.
Prazn
force-pushed
the
nip/T1657-Fix_invoice_generation_for_sub_proposal
branch
from
75837c6
to
ee4ba98
Compare
|
ecino
approved these changes
Aug 20, 2024
ecino
pushed a commit
that referenced
this pull request
Aug 27, 2024
* might have fixed the bug, still need to test. Changed logic of how invoices are generated, specially in the case where we pass a specific conteact to generate the invoices of. * handle case where more than one open invoice found,might remove this later * cleanups * trying to make code clearer, not fully satisfied... * removed comment * ruff-format * lines too long * more cleanups * pre-commit... again... * clean * PR suggestions * improved handling of grouped contracts * rebased branch and fixed mapping over properties * moved comment * removed code specific to sub proposal (moved to compassion-module), cleanups * raise error instead of logging when more than one open invoice found * ruff-format, should all be good now, hopefully...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug that occurs when generating the invoices for a new Sub Proposal, some invoices are not generated at all.
When looking into it it seems that the check of if we need to generate the invoice was wrong because it did not take into account for which contract we are generating the invoice for. Meaning that if any other active contract already had an invoice for that month, we would skip it.
Technical Aspects
There area lot of small changes here and there, to make things simple two aspects were changed :
Misc
move.pyis just related to pre-commit formatting