[IMP] Avoid duplicate sendings in mass communications

CompassionCH · Sep 17, 2024 · ac4a514 · ac4a514
1 parent 7d252e8
commit ac4a514
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/partner_communication/wizards/generate_communication_wizard.py b/partner_communication/wizards/generate_communication_wizard.py
@@ -120,7 +120,17 @@ def close(self):
 
  def generate_communications(self, async_mode=True):
  """Create the communication records"""
+ processed_addresses = set()
+ send_mode = self.send_mode or self.model_id.send_mode
  for partner in self.partner_ids:
+ address = (
+ partner.email
+ if "digital" in send_mode
+ else f"{partner.zip} {partner.city}"
+ )
+ if address in processed_addresses:
+ continue
+ processed_addresses.add(address)
  vals = {
  "partner_id": partner.id,
  "object_ids": partner.id,

diff --git a/sbc_compassion/models/correspondence.py b/sbc_compassion/models/correspondence.py
@@ -234,8 +234,7 @@ class Correspondence(models.Model):
  # Letter remote access
  ######################
  uuid = fields.Char(
- required=True, default=lambda self: self._get_uuid(),
- copy=False, index=True
+ required=True, default=lambda self: self._get_uuid(), copy=False, index=True
  )
  read_url = fields.Char(compute="_compute_read_url", store=True)