FIX missing URL in some letters

sbc_compassion/__manifest__.py

@@ -28,7 +28,7 @@
 # pylint: disable=C8101
 {
     "name": "Sponsor to Participant communication",
-    "version": "14.0.1.0.1",
+    "version": "14.0.1.0.2",
     "category": "Compassion",
     "summary": "SBC - Supporter to Participant Communication",
     "sequence": 150,

sbc_compassion/migrations/14.0.1.0.2/post-migration.py

@@ -0,0 +1,8 @@
+from openupgradelib import openupgrade
+
+
+@openupgrade.migrate()
+def migrate(env, version):
+    if version:
+        letters = env["correspondence"].search([("read_url", "=", False), ("uuid", "!=", False)])
+        letters.with_delay()._compute_read_url()

sbc_compassion/models/correspondence.py

@@ -234,7 +234,7 @@ class Correspondence(models.Model):
     # Letter remote access
     ######################
     uuid = fields.Char(required=True, default=lambda self: self._get_uuid())
-    read_url = fields.Char()
+    read_url = fields.Char(compute="_compute_read_url", store=True)
 
     # 5. SQL Constraints
     ####################
@@ -445,6 +445,11 @@ def _compute_valid_language(self):
                         lang and lang in letter.supporter_languages_ids
                     )
 
+    @api.depends("uuid")
+    def _compute_read_url(self):
+        for letter in self:
+            letter.read_url = f"{letter.get_base_url()}/b2s_image?id={letter.uuid}"
+
     ##########################################################################
     #                              ORM METHODS                               #
     ##########################################################################
@@ -735,8 +740,6 @@ def process_letter(self):
             self.env["ir.config_parameter"].sudo().get_param("web.external.url", "")
         )
         self.download_attach_letter_image(letter_type="final_letter_url")
-        for letter in self:
-            letter.read_url = f"{base_url}/b2s_image?id={letter.uuid}"
         return True
 
     def download_attach_letter_image(self, letter_type="final_letter_url"):
@@ -1007,6 +1010,10 @@ def create_text_boxes(self):
 
         return paragraphs
 
+    def get_base_url(self):
+        # Use external URL for letter access
+        return self.env["ir.config_parameter"].sudo().get_param("web.external.url", "")
+
     ##########################################################################
     #                            PRIVATE METHODS                             #
     ##########################################################################