Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix t1710 display correspondent field in survival sponsorship #1960

Merged

Conversation

Gordack
Copy link
Contributor

@Gordack Gordack commented Sep 4, 2024

Add survival sponsorship to sponsorship types

@Gordack Gordack requested a review from ecino September 4, 2024 06:53
Copy link
Member

@ecino ecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has too many side effects because this list is used at different places. It won't behave properly for some cases if survival sponsorships are included in the list.

The appropriate change is to inherit the res.partner method def _compute_related_contracts(self): in module survival_sponsorship_compassion in order to add the survival sponsorships to the relations.

@ecino ecino force-pushed the FIX-T1710-display-correspondent-field-in-Survival-sponsorship branch from e2dc804 to 56e9c7e Compare September 30, 2024 08:20
@ecino ecino force-pushed the FIX-T1710-display-correspondent-field-in-Survival-sponsorship branch from 56e9c7e to 996763d Compare September 30, 2024 08:22
Copy link

sonarcloud bot commented Sep 30, 2024

@ecino ecino merged commit 1420e0a into 14.0 Sep 30, 2024
2 checks passed
@ecino ecino deleted the FIX-T1710-display-correspondent-field-in-Survival-sponsorship branch September 30, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants