Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T0024 - Automatic reminder for invalid partners #1663

Open
wants to merge 5 commits into
base: 14.0
Choose a base branch
from

Conversation

Gordack
Copy link
Contributor

@Gordack Gordack commented Sep 19, 2024

A scheduled action should be created, similar to :
image

After test with MailHog, the following output is obtained :
image

@Gordack Gordack requested a review from ecino September 19, 2024 06:49
Copy link
Member

@ecino ecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark and another general question : Could we simply automatically archive the found contacts (and still send the notification email to SDS)? Then in the email we could simply write: "Those following contacts were found and automatically archived". That means writing {"archive": True} on them.

…ontact.xml

Co-authored-by: ecino <ecino@users.noreply.github.com>
Copy link

sonarcloud bot commented Sep 26, 2024

@Gordack
Copy link
Contributor Author

Gordack commented Sep 26, 2024

One small remark and another general question : Could we simply automatically archive the found contacts (and still send the notification email to SDS)? Then in the email we could simply write: "Those following contacts were found and automatically archived". That means writing {"archive": True} on them.

When I discussed that with Sarah, she was not so happy about the idea of automating the archive part, because she was scared that Odoo would archive people that should not be archived. Therefore, when we discussed that with Andre, we choose to not automatically archive first, in order to let SDS check that the people we propose to archive are the good ones. But yes, if SDS is happy with how the criteria are set, it would be better to archive the people that need to be archived automatically.

@ecino
Copy link
Member

ecino commented Sep 26, 2024

Waiting Sarah's feedback in order to know whether we should directly archive those contacts or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants