Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T0407 [ADD] website_sponsorship inspired by old module sms_sponsorship #1

Merged
merged 4 commits into from
Aug 8, 2023
Merged

T0407 [ADD] website_sponsorship inspired by old module sms_sponsorship #1

merged 4 commits into from
Aug 8, 2023

Conversation

ecino
Copy link
Member

@ecino ecino commented Aug 3, 2023

  • Replace REACT webapp with new website components
  • TODO README
  • TODO Pretty child description

@ecino ecino requested a review from NoeBerdoz August 3, 2023 20:50
@ecino
Copy link
Member Author

ecino commented Aug 3, 2023

@simgonzalez you can review as well

simgonzalez
simgonzalez reviewed Aug 4, 2023
View reviewed changes
website_sponsorship/wizards/abstract_partner_form.py Outdated Show resolved Hide resolved
website_sponsorship/views/data_protection_view.xml Outdated Show resolved Hide resolved
website_sponsorship/views/child_view.xml Outdated Show resolved Hide resolved
website_sponsorship/templates/sponsorship_form.xml Show resolved Hide resolved
website_sponsorship/templates/sponsorship_form.xml Outdated Show resolved Hide resolved
website_sponsorship/templates/children_page.xml Outdated Show resolved Hide resolved
website_sponsorship/templates/child_page.xml Outdated Show resolved Hide resolved
website_sponsorship/controllers/__init__.py Outdated Show resolved Hide resolved
website_sponsorship/models/compassion_child.py Outdated Show resolved Hide resolved
website_sponsorship/models/compassion_child.py Outdated Show resolved Hide resolved
simgonzalez
simgonzalez reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@simgonzalez simgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No must to have.

@ecino
T0407 [ADD] website_sponsorship inspired by old module sms_sponsorship
a56c208 
- Replace REACT webapp with new website components
- TODO Pretty child description
ecino and others added 2 commits August 7, 2023 13:41
@ecino @simgonzalez
Apply suggestions from code review
d2fc1cb 
Co-authored-by: Simon Gonzalez <45272875+simgonzalez@users.noreply.github.com>
@ecino @simgonzalez
Apply suggestions from code review
67cf4a3 
Co-authored-by: Simon Gonzalez <45272875+simgonzalez@users.noreply.github.com>
@ecino ecino requested a review from simgonzalez August 7, 2023 12:32
@ecino ecino merged commit 45f60b1 into 14.0 Aug 8, 2023
1 check failed
@ecino ecino deleted the 14.0-website-sponsorship branch August 8, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simgonzalez simgonzalez simgonzalez approved these changes

@NoeBerdoz NoeBerdoz NoeBerdoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecino @NoeBerdoz @simgonzalez