Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T1808 - Sponsor cannot see terminated child before being notified of exit #42

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

Prazn
Copy link
Contributor

@Prazn Prazn commented Sep 12, 2024

Description

When a sponsorship ends because of a child departure, until the sponsor is notified about the departure he should still be able to see the child in MyCompassion. It seems that the child is still shown in /my/children, however in /my/donations the child is not listed anymore so sponsors could figure out that the child has exited.

Technical Aspects

  • Refactored code to use same logic for fetching "active" sponsorships in both /my/children and /my/donations

@Prazn Prazn self-assigned this Sep 12, 2024
@Prazn Prazn marked this pull request as ready for review September 13, 2024 12:33
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Prazn
Copy link
Contributor Author

Prazn commented Sep 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

There seems to be a bug with SonarCloud, I applied the suggested change but the code in SonarCloud's side has not been updated, so it still fails the check...

@ecino ecino merged commit 1631700 into 14.0 Sep 23, 2024
0 of 2 checks passed
@ecino ecino deleted the nip/T1808-FixSponsorCannotSeeExitChild branch September 23, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants