Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T1889 cannot send letter on mycompassion #53

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

nlachat-compassion
Copy link
Contributor

@nlachat-compassion nlachat-compassion commented Nov 14, 2024

This PR adds an error message when a user tries to send/preview a letter but the text of the letter is empty.

image

It is impossible to know if this was the original cause of the error reported by the user, but in any case this makes the UI clearer and we will be certain in the future that the cause of the error message is not that the letter text is empty.

@nlachat-compassion nlachat-compassion marked this pull request as draft November 14, 2024 10:36
@nlachat-compassion nlachat-compassion self-assigned this Nov 14, 2024
@nlachat-compassion nlachat-compassion marked this pull request as ready for review November 14, 2024 13:32
my_compassion/i18n/de.po Outdated Show resolved Hide resolved
Fix translation Sie -> Du

Co-authored-by: ecino <ecino@users.noreply.github.com>
Copy link

sonarcloud bot commented Nov 18, 2024

@ecino ecino merged commit bb4d4e5 into 14.0 Nov 18, 2024
2 checks passed
@ecino ecino deleted the T1889-cannot-send-letter-on-mycompassion branch November 18, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants