Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to hide compliance check result #176

Merged

Conversation

Vincent056
Copy link

We are going to add a helper rule to detect HyperShift/OCP version, and we want to be able to hide the rule since it doesn't serve any purpose than providing API endpoint path.

@Vincent056
Copy link
Author

Needed to add some e2e test for this PR

@openshift-ci openshift-ci bot added the approved label Nov 4, 2022
@Vincent056 Vincent056 force-pushed the ocp_version branch 3 times, most recently from 8365198 to 2446620 Compare November 5, 2022 19:26
@Vincent056 Vincent056 changed the title WIP add ability to hide compliance check result add ability to hide compliance check result Nov 5, 2022
Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I'm not going to formally lgtm until we release the next point version to make sure we only include the changes we need.

@jhrozek
Copy link

jhrozek commented Nov 5, 2022

actually also
/hold
for the reason above

Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Annotations vs Labels thingy is a bug. Unsure about the changelog blob, that's a nitpick..
Otherwise looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
cmd/manager/aggregator.go Outdated Show resolved Hide resolved
pkg/profileparser/profileparser.go Outdated Show resolved Hide resolved
@Vincent056 Vincent056 force-pushed the ocp_version branch 3 times, most recently from a97e735 to c2a22e7 Compare November 14, 2022 07:55
Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me and works fine with ComplianceAsCode/content#9726

Do you know why is the CI failing?

Please also remember to document the variables in CO's changelog, but that can be done in a future CO patch.

@Vincent056
Copy link
Author

The code looks good to me and works fine with ComplianceAsCode/content#9726

Do you know why is the CI failing?

Please also remember to document the variables in CO's changelog, but that can be done in a future CO patch.

Took a while to figure out what was wrong, it the scan is supposed to be not applicable at the first place, and we shouldn't find CCR object.

We are going to add a helper rule to detect HyperShift/OCP version, and we want to be able to hide the rule since it doesn't serve any purpose than providing api endpoint path
@Vincent056
Copy link
Author

@jhrozek e2e passed!

Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhrozek
Copy link

jhrozek commented Nov 15, 2022

adding the no-FF labels out of band: This is in itself an internal change. Documentation, testing and PX will come later with a more thorough support for HyperShift.

@jhrozek
Copy link

jhrozek commented Nov 16, 2022

/hold cancel
I think the commit is actually pretty safe and it would help to be able to test hypershift guest clusters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants