-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to hide compliance check result #176
add ability to hide compliance check result #176
Conversation
Needed to add some e2e test for this PR |
8365198
to
2446620
Compare
2446620
to
a5d829b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I'm not going to formally lgtm until we release the next point version to make sure we only include the changes we need.
actually also |
a5d829b
to
f675261
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Annotations vs Labels thingy is a bug. Unsure about the changelog blob, that's a nitpick..
Otherwise looks good.
a97e735
to
c2a22e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me and works fine with ComplianceAsCode/content#9726
Do you know why is the CI failing?
Please also remember to document the variables in CO's changelog, but that can be done in a future CO patch.
Took a while to figure out what was wrong, it the scan is supposed to be not applicable at the first place, and we shouldn't find CCR object. |
We are going to add a helper rule to detect HyperShift/OCP version, and we want to be able to hide the rule since it doesn't serve any purpose than providing api endpoint path
c2a22e7
to
f4ff9f2
Compare
@jhrozek e2e passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhrozek, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adding the no-FF labels out of band: This is in itself an internal change. Documentation, testing and PX will come later with a more thorough support for HyperShift. |
/hold cancel |
We are going to add a helper rule to detect HyperShift/OCP version, and we want to be able to hide the rule since it doesn't serve any purpose than providing API endpoint path.