Run 'make bundle' to commit bundle manifest changes #304
Conversation
In cac/content testing, we are now using nightly operator images, which are built after every commit to cac/compliance-operator. However, bundle manifests are only refreshed on release, which means that some code changes like rbac modifications are not reflected. This causes CI failures in cac/content unless we release.
| @@ -1027,6 +1027,8 @@ spec: | |||
| - compliance.openshift.io | |||
| resources: | |||
| - compliancesuites | |||
| - scansettings | |||
| - scansettingbindings | |||
There was a problem hiding this comment.
This will effectively be overwritten the next time we do a release, right?
There was a problem hiding this comment.
more likely the release will be a noop when it comes to updating the bundle
There was a problem hiding this comment.
better worded: calling the make release target calls make bundle which will do nothing. The rest of the release target should proceed as usual.
There was a problem hiding this comment.
Ok - I still think we should find a way where we don't have to do this, but this will at least unblock us while we get another release ready.
There was a problem hiding this comment.
OK, I'll be glad to review any proposal, I admit that this is just an approach I stole from SPO..
thanks for the review!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhrozek, rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In cac/content testing, we are now using nightly operator images, which
are built after every commit to cac/compliance-operator. However,
bundle manifests are only refreshed on release, which means that some
code changes like rbac modifications are not reflected.
This causes CI failures in cac/content unless we release.