Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.1.0 #353

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Release v1.1.0 #353

merged 1 commit into from
Jul 20, 2023

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Jun 12, 2023

No description provided.

@rhmdnd rhmdnd requested review from jhrozek and Vincent056 and removed request for mrogers950 June 12, 2023 21:40
jhrozek
jhrozek approved these changes Jun 13, 2023
View reviewed changes
Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 13, 2023
@jhrozek
Copy link

jhrozek commented Jun 13, 2023

/hold
in case PR #354 needs to go first

@jhrozek jhrozek mentioned this pull request Jun 13, 2023
Merged
@rhmdnd
Copy link
Author

rhmdnd commented Jun 13, 2023

in case PR #354 needs to go first

I had to push the ocp-1.0 branch changes manually for this PR anyway. So long as the release PR looks good, I think we can move forward without merging #354 (it'll just be ready for the next upstream release).

@openshift-ci openshift-ci bot removed the lgtm label Jun 13, 2023
Vincent056
Vincent056 approved these changes Jun 13, 2023
View reviewed changes
Copy link

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Vincent056,jhrozek,rhmdnd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhmdnd
Copy link
Author

rhmdnd commented Jul 19, 2023

This is good to go in now.

@jhrozek
Copy link

jhrozek commented Jul 19, 2023

/hold cancel

@sheriff-rh
Copy link
Collaborator

lgtm! 🚀

@xiaojiey
Copy link
Collaborator

/label qe-approved

@rhmdnd rhmdnd merged commit 557f44a into master Jul 20, 2023
@rhmdnd rhmdnd deleted the release-v1.1.0 branch July 20, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vincent056 Vincent056 Vincent056 approved these changes

@jhrozek jhrozek jhrozek approved these changes

@xiaojiey xiaojiey Awaiting requested review from xiaojiey

Assignees

@jhrozek jhrozek

@mkumku mkumku

@Vincent056 Vincent056

Labels
approved docs-approved lgtm px-approved qe-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rhmdnd @jhrozek @sheriff-rh @xiaojiey @Vincent056 @mkumku @openshift-merge-robot