-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use git describe for finding operator version #500
Use git describe for finding operator version #500
Conversation
/hold for test |
Verification passed with 4.16.0-0.nightly-2024-04-01-213440 + compliance-operator from pr #500 code
|
/unhold |
/label qe-aprroved |
@BhargaviGudi: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We need to be able to set the `replaces` attribute of the CSV file so that OLM can build a relationship between dependencies, which is important for disconnected installations and upgrades. Previously, we were using the version in the CSV file, which worked but it would change within the `make prepare-release` target depending on when the command was invoked. This commit updates the version script to use `git describe` instead, which makes finding the current version more robust since tagging isn't done until a subsequent step of the release process.
ba6e883
to
0265d4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The CSV file is updated to contain:
replaces: compliance-operator.v1.4.1
version: 1.4.2
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
e4660fe
into
ComplianceAsCode:master
We need to be able to set the
replaces
attribute of the CSV file sothat OLM can build a relationship between dependencies, which is
important for disconnected installations and upgrades.
Previously, we were using the version in the CSV file, which worked but
it would change within the
make prepare-release
target depending onwhen the command was invoked.
This commit updates the version script to use
git describe
instead,which makes finding the current version more robust since tagging isn't
done until a subsequent step of the release process.