Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to clusterlogforwarder in observability API #616

Conversation

yuumasato
Copy link
Member

@yuumasato yuumasato commented Oct 2, 2024

In cluster logging operator 6.0 the ClusterlogForwarder moved from logging.openshift.io to observability.openshift.io.

CO will need to access ClusterlogForwarder from both APIs.

In cluster logging operator 6.0 the clusterlogforwarder moved
from logging.openshift.io to observability.openshift.io.
Copy link

github-actions bot commented Oct 2, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:616-90eb2a7d38700266b6bd9a02a537323dc8c0e026

Copy link

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuumasato
Copy link
Member Author

/retest

1 similar comment
@yuumasato
Copy link
Member Author

/retest

Copy link

openshift-ci bot commented Oct 8, 2024

@yuumasato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-rosa 90eb2a7 link true /test e2e-rosa

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

ROSA failures are unrelated.

Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Vincent056,rhmdnd,yuumasato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhmdnd rhmdnd merged commit 5972982 into ComplianceAsCode:master Oct 10, 2024
13 of 16 checks passed
@yuumasato yuumasato deleted the access_clusterlogforwarder_observability branch October 11, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants