-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --datastream-only
in ./build_product
#10020
Conversation
Skipping CI for Draft Pull Request. |
/packit build |
I got this error:
then, the build started |
707b515
to
79b8fbd
Compare
I just pushed an update that should fix that. |
Code Climate has analyzed commit 79b8fbd and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.8% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. I tried to run the build_product script with --datastream-only both with and without specifying a product name. In both cases it worked for me as expected. I also don't experience the error message I mentioned above.
Description:
Fixes
--datastream-only
.Rationale:
Allow use of
--datastream-only
.Review Hints:
If you run
./build_product --datastream-only
on master (772d932) you should getmake: *** No rule to make target 'generate-ssg-ALINUX2-ds.xml'. Stop.