add new rule audit_rules_immutable_login_uids #10070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtapolasek
added
New Rule
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
jan-cerny
reviewed
Jan 17, 2023
| immutable_found=0 | ||
| for f in /etc/audit/rules.d/*.rules; do | ||
| if grep -q '^\s*--loginuid-immutable\s*$' $f; then | ||
| immutable_found=1 |
| fi | ||
| else | ||
| immutable_found=0 | ||
| for f in /etc/audit/rules.d/*.rules; do |
There was a problem hiding this comment.
what if there is no .rules file in this directory?
| else | ||
| immutable_found=0 | ||
| for f in /etc/audit/rules.d/*.rules; do | ||
| if grep -q '^\s*--loginuid-immutable\s*$' $f; then |
fix indentation replace file loop with something more robust, taking advice of Shellcheck quoting the variable name
|
@jan-cerny feedback addressed in 2b8bf7e |
|
Code Climate has analyzed commit 2b8bf7e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.7% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
the rule checks for the only line "--loginuid-immutable" compared to rule audit_immutable_login_uids
It is related to this item: https://stigaview.com/products/rhel8/v1r8/RHEL-08-030122/
Fixes # Issue number here (e.g. Updating sysctl XCCDF naming #26) or remove this line if no issue exists.
Review Hints:
Review hints here. Replace this text. Don't use the italics format!
Use this optional section to give any relevant information which could help the reviewer to more quickly and assertively understand and test the changes.
Good examples are useful commands, if it is better to review all commits together or in a suggested sequence, any relevant discussion in other PRs or issues, etc.