Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the Ansible shell actions is needed in package_prelink_remove #10086

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 18, 2023

Description:

Replace ansible.builtin.shell with ansible.builtin.command in package_prelink_remove.

Rationale:

Fix Ansible lint issues.

@Mab879 Mab879 added bugfix Fixes to reported bugs. Ansible Ansible remediation update. labels Jan 18, 2023
@Mab879 Mab879 added this to the 0.1.66 milestone Jan 18, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel7 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
ansible remediation for rule 'xccdf_org.ssgproject.content_rule_package_prelink_removed' differs.
--- xccdf_org.ssgproject.content_rule_package_prelink_removed
+++ xccdf_org.ssgproject.content_rule_package_prelink_removed
@@ -13,7 +13,7 @@
 - package_prelink_removed
 
 - name: Restore Prelinked Binaries
- ansible.builtin.shell:
+ ansible.builtin.command:
 cmd: prelink -ua
 when: prelink.stat.exists
 tags:

@codeclimate
Copy link

codeclimate bot commented Jan 18, 2023

Code Climate has analyzed commit 09274bc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.7% (0.0% change).

View more on Code Climate.

@vojtapolasek vojtapolasek self-assigned this Jan 19, 2023
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this bug.
Automatus is failing because the rule has only rhel7 and some ubuntu in prodtype. I tested the rule on local RHEL7 VM and tests pass.

@vojtapolasek vojtapolasek merged commit 8157a8d into ComplianceAsCode:master Jan 19, 2023
@Mab879 Mab879 deleted the fix_ansible_lint_issues branch January 19, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. bugfix Fixes to reported bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants