Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SCE integrity checks for RHEL8 #10165

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

nightmared
Copy link
Contributor

Description:

Enable SCE integrity checks for RHEL8: as we build the datastream ourselves, we need to ensure we insert the proper SCE metadata inside that datastream.

Rationale:

Currently, the SCE check runs only for the ubuntu20.04 target, because that was the only platform that supplied an "upstream" SCE checks (there is corporate "downstream" projects that incorporate SCE checks on top of CAC).

This is a bit weak, as removing this platform would be enough to silence errors in the datastream regarding SCE checks.

This changed with the integration of the ssh_keys_passphrase_protected SCE check for RHEL8 targets in #10017.

This was made possible by the integration of the ssh_keys_passphrase_protected SCE check in
ComplianceAsCode#10017.
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 4, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2023

Hi @nightmared. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Feb 4, 2023

Code Climate has analyzed commit 6aa11ee and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Feb 6, 2023
@Mab879 Mab879 added this to the 0.1.67 milestone Feb 6, 2023
@Mab879 Mab879 added the Infrastructure Our content build system label Feb 6, 2023
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test passes on RHEL 8 and Ubuntu 20.04 content. Thanks for the PR!

@Mab879 Mab879 merged commit 2d85795 into ComplianceAsCode:master Feb 6, 2023
@nightmared nightmared deleted the enable-sce-test-rhel8 branch February 13, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants