Include warning for NetworkManager keyfiles in RHEL9 #10330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHEL9 prefers and recommends to use NetworkManager keyfiles instead of the ifcfg format for NIC configuration. New NICs will be automatically configured in the NM keyfiles format by default. However, if the system was upgraded from a RHEL8, the settings for existing NICs will remain stored in ifcfg format. They should be migrated to the NM keyfiles format by the Admins. It was included a warning in the firewalld_sshd_port_enabled rule to create more awareness for admins.
marcusburghardt
added
Highlight
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 436a375 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.7% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
RHEL9 prefers and recommends to use NetworkManager
keyfilesinstead of theifcfgformat for NIC configuration.New NICs will be automatically configured in the NM keyfiles format by default.
However, if the system was upgraded from a RHEL8, for example, the settings for existing NICs will remain stored in
ifcfgformat and thefirewalld_sshd_port_enabledwill fail.They NIC settings should be migrated to the NM keyfiles format by the Admins.
It was included a warning in the
firewalld_sshd_port_enabledrule to create more awareness for admins.Rationale:
More awareness for corner cases.