Require OVAL ID to match rule ID #10346
Conversation
…tch rule name OVAL definition in './linux_os/guide/system/software/integrity/fips/sysctl_crypto_fips_enabled/oval/rhcos4.xml' doesn't match rule ID 'sysctl_crypto_fips_enabled'.
… rule ID There was only one rule not to meet this requirement. When we meet the check, it is huge help when debugging / searching rules.
|
Hi @maage. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 5fa2ed4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.8% (0.0% change). View more on Code Climate. |
|
I don't seem to have access, but I wonder if that is related. |
Looks its related, but since how the tests are designed I'm not too concerned. |
Description:
Change behaviour to fail if OVAL ID does not match rule ID. Fixed sole failed rule.
Rationale:
There was only one rule not to meet this requirement. When we meet the
check, it is huge help when debugging / searching rules.
Also currently these kind of messages are easy not to notice.
Review Hints:
Especially should check
sysctl_crypto_fips_enabled/proc_sys_crypto_fips_enabledunder rhcos4.Tests should fail simply if there is issues.