Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package_cups_removed to Ubuntu CIS Level 2 Worstation profiles #10360

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Add package_cups_removed to Ubuntu CIS Level 2 Worstation profiles #10360

merged 2 commits into from
Mar 24, 2023

Conversation

dodys
Copy link
Contributor

@dodys dodys commented Mar 24, 2023

Description:

  • This rule was missing in the cis_level2_workstation.profile for both Ubuntu 20.04 and 22.04

Rationale:

  • This is needed for CIS on both Ubuntu 20.04 and 22.04

@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. labels Mar 24, 2023
@dodys dodys requested a review from a team as a code owner March 24, 2023 11:41
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Mar 24, 2023
@Mab879 Mab879 added this to the 0.1.67 milestone Mar 24, 2023
@Mab879 Mab879 self-assigned this Mar 24, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Mar 24, 2023

Code Climate has analyzed commit c6babbe and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.9% (0.0% change).

View more on Code Climate.

Mab879
Mab879 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Mab879
Copy link
Member

Mab879 commented Mar 24, 2023

Overidding the CODEONWERS as @dodys cannot approve his own PR.

@Mab879 Mab879 merged commit 5675189 into ComplianceAsCode:master Mar 24, 2023
@dodys dodys deleted the cups branch April 17, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
CIS CIS Benchmark related. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.67
Development

Successfully merging this pull request may close these issues.
2 participants
@dodys @Mab879