Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OL9 STIG profile #10407

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Mar 31, 2023

Description:

  • Update OL9 stig profile to also use srg control

Rationale:

  • This approximates better to a STIG requirement for the system

Review Hints:

  • This doesn't change behavior, only effects OL9 STIG rule selection

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker Xeicker requested a review from a team as a code owner March 31, 2023 19:10
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Mar 31, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 31, 2023

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Mar 31, 2023
@Mab879 Mab879 added this to the 0.1.68 milestone Mar 31, 2023
@Mab879 Mab879 added Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates. STIG STIG Benchmark related. labels Mar 31, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 31, 2023

Code Climate has analyzed commit 5b2ebed and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.8% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 removed their assignment Apr 2, 2023
Copy link
Contributor

@freddieRv freddieRv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Thanks for the efforts @Xeicker

@freddieRv freddieRv merged commit a5e2d2a into ComplianceAsCode:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Oracle Linux Oracle Linux product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants