Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sysctl sysctl_net_ipv6_conf_all_disable_ipv6 rule to CIS 3.1.1 #10475

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Add sysctl sysctl_net_ipv6_conf_all_disable_ipv6 rule to CIS 3.1.1 #10475

merged 1 commit into from
Apr 21, 2023

Conversation

teacup-on-rockingchair
Copy link
Contributor

Description:

  • Include sysctl_net_ipv6_conf_all_disable_ipv6 rule, to CIS requirement 3.1.1 for SLE platforms.

Rationale:

  • Update rule references
  • Update CIS controls for sle12 and sle15
  • Allocate CCEs

@teacup-on-rockingchair
Add sysctl disable_ipv6 rule to CIS 3.1.1
c1e53c9 
- Include sysctl_net_ipv6_conf_all_disable_ipv6 rule,
  to CIS requirement 3.1.1 for SLE platforms.
- Update CIS controls for sle12 and sle15
- Allocate CCEs
@teacup-on-rockingchair teacup-on-rockingchair requested a review from a team as a code owner April 20, 2023 19:57
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2023

Hi @teacup-on-rockingchair. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Apr 20, 2023
@Mab879 Mab879 added this to the 0.1.68 milestone Apr 20, 2023
@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Apr 20, 2023
@codeclimate
Copy link

codeclimate bot commented Apr 20, 2023

Code Climate has analyzed commit c1e53c9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Apr 21, 2023

I'm waving the Ansible test as this doesn't seem to caused by this PR.

Mab879
Mab879 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Mab879
Copy link
Member

Mab879 commented Apr 21, 2023

Overriding the CODEOWNERS as @teacup-on-rockingchair cannot approve his own PRs.

@Mab879 Mab879 merged commit 0b6999c into ComplianceAsCode:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.68
Development

Successfully merging this pull request may close these issues.
2 participants
@teacup-on-rockingchair @Mab879