Link api_server_encryption_provider_cipher with CIS 2.8 #10494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CIS 1.3 control encrypt etcd is solved with the rule api_server_encryption_provider_cipher. Because encrypting etcd is quite an important control, we should have the rule linked.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 0b628c8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.4% (0.0% change). View more on Code Climate. |
Mab879
added
CIS
rhmdnd
approved these changes
Jun 8, 2023
| @@ -113,6 +113,7 @@ selections: | |||
| - api_server_etcd_ca | |||
| # 1.2.33 Ensure that the --encryption-provider-config argument is set as appropriate | |||
| # 1.2.34 Ensure that encryption providers are appropriately configured | |||
| # 2.8 Encrypt etc | |||
There was a problem hiding this comment.
Looks good - but for some reason control 2.8 was removed in version 1.4.0 of the benchmark.. We'll just have to update this later (or let it disappear if we decide to use the new control file format).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Links an OCP rule with the appropriate CIS control
Rationale:
CIS 1.3 control encrypt etcd is solved with the rule
api_server_encryption_provider_cipher. Because encrypting etcd is quite
an important control, we should have the rule linked.
Review Hints: