install-vm fixes / features

[maage]

Description:

I have used install-vm and some pain points here.

Support biosboot in newer Fedora.
Support option --disk-unsafe, there is --disk where I can put all kinds of entries, but I rather have cache=unsafe from start and use defaults. Changed how disk_spec is handled.

Use argparse.ArgumentDefaultsHelpFormatter to get nicer help.

Allow to run from other directory than 'tests'.

Rationale:

Small contained improvements needed.

Review Hints:

I have also CentOS 7 machine and there is no regression.

[openshift-ci]

Hi @maage. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment

Oracle Linux 8 Environment

[codeclimate]

Code Climate has analyzed commit ba73850 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4%.

View more on Code Climate.

[vojtapolasek]

Looks good. I tested it with standard installation of RHEL 8 (affected by biosboot addition) and it works as expected.