Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eks platforms to some ocp shared OVAL #10610

Merged
merged 1 commit into from
May 23, 2023

Conversation

matejak
Copy link
Member

@matejak matejak commented May 23, 2023

Shared OVALs may get into content of a wider range of products, and it is better to preventatively include those checks, as the project can't do that on-demand at this time.

Review Hints:

  • Check the linked issue, the fix ensures that the platform definition is present both on OCP4 and EKS products, and forward-compatibility has been established by using the platform classes rather than platforms.

Shared OVALs may get into content of a wider range of products,
and it is better to preventatively include those checks,
as the project can't do that on-demand at this time.
@matejak matejak added this to the 0.1.68 milestone May 23, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented May 23, 2023

Code Climate has analyzed commit 0e5ffb6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.5% (0.0% change).

View more on Code Climate.

@vojtapolasek vojtapolasek self-assigned this May 23, 2023
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it fixes the issue. Thank you.

@vojtapolasek vojtapolasek merged commit 0c6b8fb into ComplianceAsCode:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EKS Datastream fails SCAPVal
2 participants