Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRG-APP-000441-CTR-001090,SRG-APP-000442-CTR-001095: Add justification to a rule that's inherently met #10614

Merged
merged 1 commit into from
Jun 8, 2023
Merged

SRG-APP-000441-CTR-001090,SRG-APP-000442-CTR-001095: Add justification to a rule that's inherently met #10614

merged 1 commit into from
Jun 8, 2023

Conversation

jhrozek
Copy link
Collaborator

@jhrozek jhrozek commented May 23, 2023

Description:

  • Fixes two issues: - SRG-APP-000441-CTR-001090 included rules even though the SRG is inherently met and neither SRG-APP-000441-CTR-001090 nor SRG-APP-000442-CTR-001095 included status justification or artifact description

Rationale:

  • OCP4 STIG

Review Hints:

  • I will post SRG export when it's generated

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented May 23, 2023

Code Climate has analyzed commit ec53b8b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added the OpenShift OpenShift product related. label May 23, 2023
@jhrozek
Copy link
Collaborator Author

jhrozek commented May 24, 2023

@Vincent056 @rhmdnd PTAL.
To review, please compare the latest STIG draft with the SRG export

@jhrozek
Copy link
Collaborator Author

jhrozek commented May 24, 2023

CC @xiaojiey for awareness. I don't think there's much to test for QE, this is just metadata in the control files

@rhmdnd rhmdnd merged commit f283075 into ComplianceAsCode:master Jun 8, 2023
@Mab879 Mab879 added this to the 0.1.69 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhmdnd rhmdnd rhmdnd approved these changes

Assignees

@rhmdnd rhmdnd

Labels
OpenShift OpenShift product related.
Projects
None yet
Milestone
0.1.69
Development

Successfully merging this pull request may close these issues.
3 participants
@jhrozek @rhmdnd @Mab879