Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync rules that contain a stig ID to those in stig profiles for ol products #10632

Merged
merged 2 commits into from
May 25, 2023
Merged

Sync rules that contain a stig ID to those in stig profiles for ol products #10632

merged 2 commits into from
May 25, 2023

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented May 24, 2023

Description:

  • Added/removed Stig Id from rules
  • Added/removed rules from stig profiles

Rationale:

  • This ensures there are no rules with a STIG ID assigned but not used in STIG profile. At least in OL products

Review Hints:

  • This is entirely about OL, no behavior change

Xeicker added 2 commits May 24, 2023 15:58
@Xeicker
Sync OL7 stig profile with stigids in rules
72f3e14 
Ensure all rules in OL7 stig profile and only those have a stig id
assigned

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker
Sync OL8 stig profile with stigids in rules
6902cb0 
Ensure all rules in OL8 stig profile and only those have a stig id
assigned

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker Xeicker requested a review from a team as a code owner May 24, 2023 22:02
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 24, 2023

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented May 24, 2023

Code Climate has analyzed commit 6902cb0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.5% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added the Oracle Linux Oracle Linux product related. label May 25, 2023
@marcusburghardt marcusburghardt requested a review from freddieRv May 25, 2023 06:35
@marcusburghardt marcusburghardt added this to the 0.1.68 milestone May 25, 2023
@freddieRv freddieRv merged commit 49363ac into ComplianceAsCode:master May 25, 2023
@jan-cerny jan-cerny added the Update Profile Issues or pull requests related to Profiles updates. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddieRv freddieRv freddieRv approved these changes

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@freddieRv freddieRv

Labels
needs-ok-to-test Used by openshift-ci bot. Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.68
Development

Successfully merging this pull request may close these issues.
4 participants
@Xeicker @marcusburghardt @freddieRv @jan-cerny