Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilization: Add git to dependencies of the stabilize workflow #10660

Conversation

jan-cerny
Copy link
Collaborator

This is a backport of #10649 to the stabilization-v0.1.68 branch.

Addressing:
Failed to find runtime dependency 'git' in PATH.

Addressing:
Failed to find runtime dependency 'git' in PATH.
The reason is that git without -core might pull extra dependencies.
@jan-cerny jan-cerny added the backported-into-stabilization PRs which were cherry-picked during stabilization process. label May 31, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this May 31, 2023
@Mab879 Mab879 added this to the 0.1.68 milestone May 31, 2023
@Mab879
Copy link
Member

Mab879 commented May 31, 2023

@jan-cerny Can you please push again? Looks like one of the required GH Actions didn't get triggered.

@ggbecker
Copy link
Member

ggbecker commented May 31, 2023

@jan-cerny Can you please push again? Looks like one of the required GH Actions didn't get triggered.

This is actually because the fact the job is not configured to run against stabilization branches:

pull_request:
branches: [ 'master' ]

Have we recently made Publish stats, tables and guides required for stabilization branches?

@Mab879
Copy link
Member

Mab879 commented May 31, 2023

@jan-cerny Can you please push again? Looks like one of the required GH Actions didn't get triggered.

This is actually because the fact the job is not configured to run against stabilization branches:

pull_request:
branches: [ 'master' ]

Have we recently made Publish stats, tables and guides required for stabilization branches?

Yes @vojtapolasek made it required yesterday.

@vojtapolasek
Copy link
Collaborator

Yes, @Mab879 I did that. I had to fiddle with the configuration because of this pr #10652
When I was reverting the changes, I configured it in the same way as master... should I change it? I don't see any disadvantage if it runs against stabilization as well...

@Mab879
Copy link
Member

Mab879 commented May 31, 2023

Yes, @Mab879 I did that. I had to fiddle with the configuration because of this pr #10652 When I was reverting the changes, I configured it in the same way as master... should I change it? I don't see any disadvantage if it runs against stabilization as well...

For now we should not require it as it doesn't run stabilization, but we make run on stabilization in different PR.

@vojtapolasek
Copy link
Collaborator

@Mab879 fixed.

@Mab879 Mab879 merged commit b630293 into ComplianceAsCode:stabilization-v0.1.68 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-into-stabilization PRs which were cherry-picked during stabilization process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants