-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes in file_groupownership template #10666
fixes in file_groupownership template #10666
Commits on Jun 14, 2023
-
change parameter filegid of file_groupownership template to gid_or_name explain its behavior
Configuration menu - View commit details
-
Copy full SHA for f405e19 - Browse repository at this point
Copy the full SHA f405e19View commit details -
modify rule.yaml files to change the parameter name of file_groupowne…
…rship template from filegid to gid_or_name
Configuration menu - View commit details
-
Copy full SHA for 2616c29 - Browse repository at this point
Copy the full SHA 2616c29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ce03f5 - Browse repository at this point
Copy the full SHA 2ce03f5View commit details -
modify remediations for file_groupownership template
change the parameter name from filgeid to gid_or_name additionally, use the -group parameter instead of -gid parameter in find command invocation the -group parameter accepts both gid and group names, where the -gid parameter accepts only gid
Configuration menu - View commit details
-
Copy full SHA for 53eac6f - Browse repository at this point
Copy the full SHA 53eac6fView commit details -
modify the preprocessing function of file_groupownership template
establish a new variable which carries information if the parameter is a gid or a group name
Configuration menu - View commit details
-
Copy full SHA for d4ea27a - Browse repository at this point
Copy the full SHA d4ea27aView commit details -
modify the oval for file_groupownership template
decide if to use group ID or group name based on the variable declared in the preprocessing function change parameter name from file_gid to gid_or_name
Configuration menu - View commit details
-
Copy full SHA for a4c870b - Browse repository at this point
Copy the full SHA a4c870bView commit details -
extract duplicated function from file_(owner|groupowner|permissions) …
…templates into shared module
Configuration menu - View commit details
-
Copy full SHA for e51a832 - Browse repository at this point
Copy the full SHA e51a832View commit details -
fix test scenarios for file_(groupownership|owner|permissions) template
The test did not account for a case when a filepath is a directory and it does not exist on the system. Also the test made use of is_directory parameter which is only available at runtime when building the template and it is not saved anywhere. Instead of this parameter, scenarios now check if the path ends with a slash. This signifies the filepath is a directory as mentioned in the tempate documentation.
Configuration menu - View commit details
-
Copy full SHA for 802ceb7 - Browse repository at this point
Copy the full SHA 802ceb7View commit details -
update missing_file_test test scenarios of file_groupownership and fi…
…le_owner template These test scenarios would not work correctly if the filepath parameter was a directory.
Configuration menu - View commit details
-
Copy full SHA for 039d2a3 - Browse repository at this point
Copy the full SHA 039d2a3View commit details -
add overriding test scenario to file_groupownership_sshd_pub_key rule
This rule uses directory + regex, it needs a special test scenario because the template does only generic testing.
Configuration menu - View commit details
-
Copy full SHA for d3dcd79 - Browse repository at this point
Copy the full SHA d3dcd79View commit details
Commits on Jun 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d92169b - Browse repository at this point
Copy the full SHA d92169bView commit details
Commits on Jun 22, 2023
-
file_groupownership_ssh_private_key: make sure that the group ssh_key…
…s exists before using it in test scenario it migt not exist in FEdora container which is used as test environment
Configuration menu - View commit details
-
Copy full SHA for 181ccc5 - Browse repository at this point
Copy the full SHA 181ccc5View commit details -
file_groupownership_ssh_private_key: exclude templated test scenario
the missing_file_test test scenario should fail, not pass. At the same time, we actually can't create a new failing test scenario - removing the ssh private key will break the testing workflow.
Configuration menu - View commit details
-
Copy full SHA for 7a3e7a1 - Browse repository at this point
Copy the full SHA 7a3e7a1View commit details