Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grub2 remediation instructions #10717

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Fix grub2 remediation instructions #10717

merged 1 commit into from
Jun 15, 2023

Conversation

hfinucane
Copy link

Description:

The remediation instructions for xccdf_org.ssgproject.content_rule_grub2_admin_username are subtly wrong

Rationale:

The string it should look for is "superusers=", not "superuser=". All the other content looks for the correct string, other than the instructions provided.

Review Hints:

Double check against the tests or the grub2 docs.

Fix grub2 remediation instructions
19aeea3 
The string it should look for is "superuser*s*=", not "superuser=". All
the other content looks for the correct string, other than the
instructions provided.
@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2023

Hi @hfinucane. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 14, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879
Copy link
Member

Mab879 commented Jun 14, 2023

/packit build

@codeclimate
Copy link

codeclimate bot commented Jun 14, 2023

Code Climate has analyzed commit 19aeea3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.8% (0.0% change).

View more on Code Climate.

@jan-cerny
Copy link
Collaborator

/packit build

jan-cerny
jan-cerny approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice discovery! Thanks

@jan-cerny jan-cerny self-assigned this Jun 15, 2023
@jan-cerny jan-cerny added the Update Rule Issues or pull requests related to Rules updates. label Jun 15, 2023
@jan-cerny jan-cerny added this to the 0.1.69 milestone Jun 15, 2023
@jan-cerny jan-cerny merged commit 616d30a into ComplianceAsCode:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
needs-ok-to-test Used by openshift-ci bot. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
0.1.69
Development

Successfully merging this pull request may close these issues.
3 participants
@hfinucane @Mab879 @jan-cerny