Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRG-APP-000148-CTR-000335,SRG-APP-000190-CTR-000500: Covered by sshd_disable_root_login #10736

Merged
merged 1 commit into from
Jun 30, 2023
Merged

SRG-APP-000148-CTR-000335,SRG-APP-000190-CTR-000500: Covered by sshd_disable_root_login #10736

merged 1 commit into from
Jun 30, 2023

Conversation

jhrozek
Copy link
Collaborator

@jhrozek jhrozek commented Jun 20, 2023

Description:

  • These two SRGs are the only two ones that need a rule in the IA control family of the RHCOS4 DISA STIG

Rationale:

  • STIG

Review Hints:

  • Check the e2e test status
  • Compare the SRGs with the STIG draft

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added this to the 0.1.69 milestone Jun 20, 2023
@Mab879 Mab879 added OpenShift OpenShift product related. STIG STIG Benchmark related. labels Jun 20, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 21, 2023

Code Climate has analyzed commit 930512d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.9% (0.0% change).

View more on Code Climate.

@jhrozek
Copy link
Collaborator Author

jhrozek commented Jun 21, 2023

/test e2e-aws-rhcos4-stig

@jhrozek
Copy link
Collaborator Author

jhrozek commented Jun 21, 2023

@Vincent056 @rhmdnd PTAL

@rhmdnd rhmdnd merged commit 8947d30 into ComplianceAsCode:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhmdnd rhmdnd rhmdnd approved these changes

@Vincent056 Vincent056 Awaiting requested review from Vincent056

Assignees

@rhmdnd rhmdnd

Labels
OpenShift OpenShift product related. STIG STIG Benchmark related.
Projects
None yet
Milestone
0.1.69
Development

Successfully merging this pull request may close these issues.
3 participants
@jhrozek @rhmdnd @Mab879