Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCOS4 STIG: Cover the controls that relate to NIST SC #10742

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

jhrozek
Copy link
Collaborator

@jhrozek jhrozek commented Jun 21, 2023

Description:

  • This patch covers several controls related to NIST SC. There is one check that is not covered
    (OpenShift must set the sticky bit for world-writable directories.). For some reason, this
    control does not pass on default OCP and the directories that are world-writable but don't
    have a sticky bit set are typically in the pod mounts or rpm-ostree. I don't think there
    is much we can do except either remove that control or mark it as does not meet - but
    we can't have an automated check for it at the moment.

Rationale:

  • RHCOS STIG

Review Hints:

  • Make sure that all the rules pass the e2e tests
  • compare the rules and their intent with the DISA STIG draft

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added the OpenShift OpenShift product related. label Jun 21, 2023
@jhrozek
Copy link
Collaborator Author

jhrozek commented Jun 21, 2023

/test help

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2023

@jhrozek: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-ocp4-cis
  • /test e2e-aws-ocp4-cis-node
  • /test e2e-aws-ocp4-e8
  • /test e2e-aws-ocp4-high
  • /test e2e-aws-ocp4-high-node
  • /test e2e-aws-ocp4-moderate
  • /test e2e-aws-ocp4-moderate-node
  • /test e2e-aws-ocp4-pci-dss
  • /test e2e-aws-ocp4-pci-dss-node
  • /test e2e-aws-ocp4-stig
  • /test e2e-aws-ocp4-stig-node
  • /test e2e-aws-rhcos4-e8
  • /test e2e-aws-rhcos4-high
  • /test e2e-aws-rhcos4-moderate
  • /test e2e-aws-rhcos4-stig
  • /test images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-ComplianceAsCode-content-master-images

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhrozek
Copy link
Collaborator Author

jhrozek commented Jun 21, 2023

/test e2e-aws-rhcos4-stig

@jhrozek
Copy link
Collaborator Author

jhrozek commented Jun 22, 2023

/test e2e-aws-rhcos4-stig

2 similar comments
@jhrozek
Copy link
Collaborator Author

jhrozek commented Jun 22, 2023

/test e2e-aws-rhcos4-stig

@jhrozek
Copy link
Collaborator Author

jhrozek commented Jun 22, 2023

/test e2e-aws-rhcos4-stig

@yuumasato yuumasato self-assigned this Jul 5, 2023
@jhrozek
Copy link
Collaborator Author

jhrozek commented Jul 5, 2023

/test e2e-aws-rhcos4-stig

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just pending CI.

@yuumasato yuumasato added this to the 0.1.69 milestone Jul 5, 2023
@yuumasato
Copy link
Member

/test e2e-aws-rhcos4-stig

@codeclimate
Copy link

codeclimate bot commented Jul 5, 2023

Code Climate has analyzed commit 572a1c8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.5% (0.0% change).

View more on Code Climate.

@jhrozek
Copy link
Collaborator Author

jhrozek commented Jul 5, 2023

CI succeeded, merging

@jhrozek jhrozek merged commit a50e536 into ComplianceAsCode:master Jul 5, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants