-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openembedded distro support #10793
Conversation
Hi @akuster. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hello, I see there is a test-cmakelint error. I take it I need to correct that and do a v2 on the pull request? |
includes a standard profile for out-of-the-box checks Signed-off-by: Armin Kuster <akuster808@gmail.com> [v2] Fix cmakelint error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in review. One additional question we have is your plans on keeping this updated.
Thanks for the PR.
Use the formal name, not abbreviation. Co-authored-by: Matthew Burket <m@tthewburket.com>
Co-authored-by: Matthew Burket <m@tthewburket.com>
Co-authored-by: Matthew Burket <m@tthewburket.com>
No worries. I plan on keeping it updated. I was waiting to see if these changes where going to be accepted before sending additional changes. thanks |
Code Climate has analyzed commit e2e5226 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.3%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the PR!
includes a standard profile for out-of-the-box checks
Description:
This enables support for an OpenEmbedded based system. OpenEmbedded is a Framework for building a custom distribution. One such distribution is the Yocto Project's "Poky reference distribution". Openscap and scap-security-guide are part of a security layer I maintain which allows users to add security applications to their builds.
Rationale:
In the spirit of opensource I am upstream my changes. I am not sure if this meet the intent or objective of the project. I wanted to included a baseline set of tests that pass if run on on a default build.