Add validation for Keys in Controls #10813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit aa10861 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.5% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
I have verified that it fixes #9772 in a nice way, this happened when using a wrong key (rule instead of rules):
RuntimeError: Unable to parse controls from /home/jcerny/work/git/scap-security-guide/controls/anssi.yml: Key rule is not a valid for a control.
ninja: build stopped: subcommand failed.
|
The CI fail on Rawhide is in the installation of the Imp module and isn't related to the contents of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds test before import a control dict to ensure that it only have supported keys. To prevent unfortunate event like using
rulevsrules.Rationale:
Closes #9772
Review Hints:
Add an invalid key like
badvalto a control in a control file and the build should fail.