Improve OVAL readability in enable_fips_mode #10911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit only improves readability without any technical impact in the OVAL logic.
Simplified the comments and aligned the respective lines to the project Style Guides.
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 6a62a2f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
marcusburghardt
force-pushed
the
enable_fips_mode_readability
branch
from
69541ac
to
6a62a2f
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/packit retest-failed |
jan-cerny
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I recently reviewed another PR related to this rule and felt its readability could be improved.
This PR does not change anything in the OVAL logic, but is only about readability.
Rationale:
Better readability
Review Hints:
There is no technical impact by the changes in this PR. So, just reading the OVAL should be enough to review it.