-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce secure_boot & kernel_uek cpes and use them in sysctl_kernel_kexec_load_disabled #10919
Introduce secure_boot & kernel_uek cpes and use them in sysctl_kernel_kexec_load_disabled #10919
Conversation
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Rule sysctl_kernel_kexec_load_disabled covers STIG requirement OL08-00-010372 which is not applicable if the system is running with secureboot enabled and with UEK>=6 Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Hi @Xeicker. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Code Climate has analyzed commit 9021f78 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
/packit retest-failed |
1 similar comment
/packit retest-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to build the content and I have seen the resolved platform file and checked test_kernel_uek and secure_boot_enabled in the generated SCAP source data stream.
The CI fail on Rawhide is caused by numpy and isn't related to the contents of this PR. |
Description:
secure_boot
cpekernel_uek
cpesysctl_kernel_kexec_load_disabled
for OL8Rationale:
OL08-00-010372
requirementReferences
Since the
secure_boot
CPE could be polemical I share my reasoning to implement it in that way. The efivar is formed by attributes bytes + var value bytes [1] and the secure boot has to have a 1 in last byte for enabled and a 0 for disabled [2]. So the only byte expected to change is the value, this way the hash should be a good indicator of the system having the secureboot enabled[1] - https://wiki.archlinux.org/title/Unified_Extensible_Firmware_Interface/Secure_Boot
[2] - https://docs.kernel.org/filesystems/efivarfs.html