Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifests to zipfile target #10944

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Aug 2, 2023

Description:

Add the manifest JSON files to the release zip file.

Rationale:

So that this data can used later to compare across releases.

So that this data can used later to compare across releases
@Mab879 Mab879 added the Infrastructure Our content build system label Aug 2, 2023
@Mab879 Mab879 added this to the 0.1.70 milestone Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@jan-cerny jan-cerny self-assigned this Aug 3, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built the zip file and I have found that the manifests dir in the zip file is empty.

@Mab879
Copy link
Member Author

Mab879 commented Aug 3, 2023

I have built the zip file and I have found that the manifests dir in the zip file is empty.

I'm unable to reproduce this. Here are the steps I did:

$ ./build_product -j10 rhel9 rhel8 rhel7 debian10 debian11
<snip>
$  ninja zipfile  
<snip>
scap-security-guide-0.1.70/tables/tables-rhel8-all.html
scap-security-guide-0.1.70/tables/tables-rhel9-all.html
scap-security-guide-0.1.70/manifests
scap-security-guide-0.1.70/manifests/manifest-debian10.json
scap-security-guide-0.1.70/manifests/manifest-debian11.json
scap-security-guide-0.1.70/manifests/manifest-rhel7.json
scap-security-guide-0.1.70/manifests/manifest-rhel8.json
scap-security-guide-0.1.70/manifests/manifest-rhel9.json
$ pwd 
/home/mburket/code/ComplianceAsCode/content/build
$ ls zipfile/scap-security-guide-0.1.70/manifests 
manifest-debian10.json  manifest-rhel7.json  manifest-rhel9.json
manifest-debian11.json  manifest-rhel8.json

@jan-cerny
Copy link
Collaborator

@Mab879 I did it the standard way: cd build; rm -rf *; cmake .. && make zipfile; It could be a target dependency issue.

@codeclimate
Copy link

codeclimate bot commented Aug 4, 2023

Code Climate has analyzed commit 5f558fb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 requested a review from jan-cerny August 4, 2023 17:24
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked that the generated zip file contain JSON manifests for all built products.

@jan-cerny jan-cerny merged commit 591a271 into ComplianceAsCode:master Aug 7, 2023
29 of 30 checks passed
@Mab879 Mab879 deleted the manifests_in_build branch August 7, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants