-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manifests to zipfile target #10944
Conversation
So that this data can used later to compare across releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have built the zip file and I have found that the manifests dir in the zip file is empty.
I'm unable to reproduce this. Here are the steps I did:
|
@Mab879 I did it the standard way: cd build; rm -rf *; cmake .. && make zipfile; It could be a target dependency issue. |
Code Climate has analyzed commit 5f558fb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked that the generated zip file contain JSON manifests for all built products.
Description:
Add the manifest JSON files to the release zip file.
Rationale:
So that this data can used later to compare across releases.